Dear Greg,
in message 428CA1FB.8000407@moreton.com.au you wrote:
Here is a reworked patch, this time against the current CVS code. How does this look?
Much better :-)
The subject ("[PATCH 1/2]") indicates that there is a second part to follow - is there? I don't see any obvious stuff missing?
* Patch by Greg Ungerer, 19 May 2005: - add support for the KS8695P (ARM 922 based) CPU - add support for the OpenGear CM4008, CM4116 and CM4148 boards
Checked in, thanks.
But please stick to the Coding Style: don't add trailing white space to files (cpu/arm920t/ks8695/lowlevel_init.S, include/asm-arm/arch-ks8695/platform.h), don't add trailing empty lines (cpu/arm920t/ks8695/interrupts.c), and don't use C++ comments (drivers/ks8695eth.c).
And instead of
#if 0 printf(...); #endif
you could simply write
debug (...);
which is easier to read and to enable if needed.