At present an invalid bus width prints a message but does not return an error. This is the opposite of the correct behaviour. Adjust it to avoid code bloat in the common case, and avoid hard-to-debug failure in the uncommon case.
Signed-off-by: Simon Glass sjg@chromium.org ---
drivers/spi/spi-uclass.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c index 26eada2..358e229 100644 --- a/drivers/spi/spi-uclass.c +++ b/drivers/spi/spi-uclass.c @@ -415,8 +415,8 @@ int spi_slave_ofdata_to_platdata(const void *blob, int node, mode |= SPI_TX_QUAD; break; default: - error("spi-tx-bus-width %d not supported\n", value); - break; + debug("spi-tx-bus-width %d not supported\n", value); + return -EPROTONOSUPPORT; }
value = fdtdec_get_uint(blob, node, "spi-rx-bus-width", 1); @@ -430,8 +430,8 @@ int spi_slave_ofdata_to_platdata(const void *blob, int node, mode |= SPI_RX_QUAD; break; default: - error("spi-rx-bus-width %d not supported\n", value); - break; + debug("spi-rx-bus-width %d not supported\n", value); + return -EPROTONOSUPPORT; }
plat->mode = mode;