Re: [U-Boot] [PATCH 5/5] doc: dt-bindings: Describe rockchip LVDS interface

On 12 March 2016 at 06:13, Jacob Chen jacob-chen@iotwrt.com wrote:

I didn't have a common board to enable LVDS. So add this dcocument to help others who want to enable LVDS in their board.

Signed-off-by: Jacob Chen jacob-chen@iotwrt.com Signed-off-by: jacob jacob-chen@iotwrt.com

---

doc/device-tree-bindings/video/rockchip-lvds.txt | 77 ++++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 doc/device-tree-bindings/video/rockchip-lvds.txt

Acked-by: Simon Glass sjg@chromium.org

Please see nit below.

diff --git a/doc/device-tree-bindings/video/rockchip-lvds.txt b/doc/device-tree-bindings/video/rockchip-lvds.txt new file mode 100644 index 0000000..60437f2 --- /dev/null +++ b/doc/device-tree-bindings/video/rockchip-lvds.txt @@ -0,0 +1,77 @@ +Rockchip LVDS interface +------------------

+(Required properties:

Do you need the '(' ?

+- compatible: "rockchip,rk3288-lvds";

+- reg: physical base address of the controller and length

•   of memory mapped region.
  

+- clocks: must include clock specifiers corresponding to entries in the

•   clock-names property.
  

+- clock-names: must contain "pclk_lvds"

+- rockchip,grf: phandle to the general register files syscon

+- rockchip,data-mapping: should be <0> for "vesa" or <1> for "jeida",

•   This describes how the color bits are laid out in the
  

•   serialized LVDS signal.
  

+- rockchip,data-width : should be <18> or <24>; +- rockchip,output: should be <0> for "rgb", <1> for "lvds" or <2> for "duallvds",

•   This describes the output face.
  

+- display-timings : described by

•   doc/devicetree/device-tree-bindings/video/display-timing.txt.
  

+Example:

•   lvds: lvds@ff96c000 {
  

•           compatible = "rockchip,rk3288-lvds";
  

•           reg = <0xff96c000 0x4000>;
  

•           clocks = <&cru PCLK_LVDS_PHY>;
  

•           clock-names = "pclk_lvds";
  

•           pinctrl-names = "default";
  

•           pinctrl-0 = <&lcdc0_ctl>;
  

•           rockchip,grf = <&grf>;
  

•           status = "disabled";
  

•           ports {
  

•                   #address-cells = <1>;
  

•                   #size-cells = <0>;
  

•                   lvds_in: port@0 {
  

•                           reg = <0>;
  

•                           #address-cells = <1>;
  

•                           #size-cells = <0>;
  

•                           lvds_in_vopb: endpoint@0 {
  

•                                   reg = <0>;
  

•                                   remote-endpoint = <&vopb_out_lvds>;
  

•                           };
  

•                           lvds_in_vopl: endpoint@1 {
  

•                                   reg = <1>;
  

•                                   remote-endpoint = <&vopl_out_lvds>;
  

•                           };
  

•                   };
  

•           };
  

•   };
  

+'

•   &lvds {
  

•           rockchip,data-mapping = <0>;
  

•           rockchip,data-width = <24>;
  

•           rockchip,output = <2>;
  

•           rockchip,panel = <&panel>;
  

•           status = "okay";
  

•           display-timings {
  

•                   timing@0 {
  

•                           clock-frequency = <40000000>;
  

•                           hactive = <1920>;
  

•                           vactive = <1080>;
  

•                           hsync-len = <44>;
  

•                           hfront-porch = <88>;
  

•                           hback-porch = <148>;
  

•                           vfront-porch = <4>;
  

•                           vback-porch = <36>;
  

•                           vsync-len = <5>;
  

•                   };
  

•           };
  

•   };
  

\ No newline at end of file

Can you add one?

-- 2.3.5

Regards, Simon