On Sun, 2008-01-13 at 10:48 +0800, Ben Warren wrote:
This patch adds support for the SPI controller found on Freescale PowerPC processors such as the MCP834x family. Additionally, a new config option, CONFIG_HARD_SPI, is added for general purpose SPI controller use.
Ben, Could you make the SPI drivers more generic/reuseable? IIRC, the 85xx part has the same SPI controller.
[snip]
+#include <common.h> +#include <spi.h> +#include <asm/immap_83xx.h>
Could you use the fsl_spi.h head? not 83xx..
[snip]
diff --git a/include/asm-ppc/immap_83xx.h b/include/asm- ppc/immap_83xx.h index 34ea295..07ff400 100644 --- a/include/asm-ppc/immap_83xx.h +++ b/include/asm-ppc/immap_83xx.h @@ -397,6 +397,18 @@ typedef struct spi83xx { u8 res1[0xFD8]; } spi83xx_t;
+typedef struct spi834x +{
u8 res0[0x20]; /* 0x0-0x01f reserved */u32 mode; /* mode register */u32 event; /* event register */u32 mask; /* mask register */u32 com; /* command register */u32 tx; /* transmit register */u32 rx; /* receive register */u8 res1[0xC8]; /* fill up to 0x100 */- } spi834x_t;
please put this into fsl_spi.h to reuse for different 8xxx family.
Thanks, Dave