On Thu, Oct 25, 2012 at 03:47:09PM -0700, Joe Hershberger wrote:
Hi Stephen,
On Thu, Oct 25, 2012 at 5:45 PM, Stephen Warren swarren@wwwdotorg.org wrote:
On 10/25/2012 04:36 PM, Joe Hershberger wrote:
Hi Allen,
On Thu, Oct 25, 2012 at 4:59 PM, Allen Martin amartin@nvidia.com wrote:
Add a new special environment variable "serial" that allows selection of serial device when CONFIG_SERIAL_MULTI is defined. This replaces the existing calls to serial_assign() from cmd_nvedit.c and iomux.c that were not doing anything.
...
Changes to this directly conflict with the environment callback series I sent out RFC (soon be be a real series). Can we hold off on this until that happens?
The problem here is that serial output on Tegra simply doesn't work (after some point in boot?) without this patch. It seems better to get everything working before adding new features doesn't it? Otherwise, if the environment callback stuff (or any other change right now) breaks something Tegra-specific, there would be no way to identify which change broke it.
Fair enough. However I don't think this patch is the right way to fix it.
Ok, would removing the existing calls to serial_assign() from iomux.c and cmd_nvedit.c be an ok first step? They don't appear to do anything useful right now and that would fix tegra and raspberry pi.
-Allen