Matthias Kaehlcke wrote:
Hi Alessandro,
El Sat, Feb 06, 2010 at 08:54:05PM +0100 Alessandro Rubini ha dit:
printf goes to uart1, but it will block forever waiting for busy to go off unless the uart is enabled first.
Signed-off-by: Alessandro Rubini rubini@gnudd.com
board/edb93xx/edb93xx.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/board/edb93xx/edb93xx.c b/board/edb93xx/edb93xx.c index 4df2246..dde30ff 100644 --- a/board/edb93xx/edb93xx.c +++ b/board/edb93xx/edb93xx.c @@ -64,6 +64,12 @@ int board_init(void) value |= SYSCON_PWRCNT_UART_BAUD; writel(value, &syscon->pwrcnt);
- /* Enable the uart in devicecfg */
- value = readl(&syscon->devicecfg);
- value |= 1<<18 /* U1EN */;
using a constant like DEVCFG_U1EN would be preferrable, as the patch is correct at the functional and coding style level i'll leave it to Tom to decide if we fix this now or later
It is ok to fix this later. The patch set have been applied. Thanks Tom