
Dear Wolfgang,
2012/9/1 Wolfgang Denk wd@denx.de:
Dear Zhizhou Zhang,
In message 1346071750-6634-7-git-send-email-etou.zh@gmail.com you wrote:
[...]
while (1) {
cache_op(Hit_Writeback_Inv_D, addr);
cache_op(Hit_Invalidate_I, addr);
We don't allow camel-case identifiers. Please fix globally.
those identifiers are from arch/mips/include/asm/cacheops.h which is imported from Linux like many other header files in U-Boot. Does it really make sense to fix the coding style of imported files?
According to http://www.denx.de/wiki/U-Boot/CodingStyle you allow exceptions: "Source files originating from different projects (for example the MTD subsystem or the hush shell code from the BusyBox project) may, after careful consideration, be exempted from these rules. For such files, the original coding style may be kept to ease subsequent migration to newer versions of those sources. "