-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/30/2014 06:05 PM, Darwin Rambo wrote:
On 14-01-29 02:33 PM, Tom Rini wrote:
On Mon, Jan 27, 2014 at 10:53:30AM -0800, Darwin Rambo wrote:
Add support for the bcm28155_ap reference board.
Signed-off-by: Darwin Rambo drambo@broadcom.com Reviewed-by: Steve Rae srae@broadcom.com Reviewed-by: Tim Kryger tkryger@linaro.org
[snip]
- gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
Please use get_ram_size(...);
We tried using this on our reference board and it hangs accessing memory regions that are not populated. Our memory controller doesn't appear to properly support accessing regions that are not backed by physical sdram. So I think it's best to keep this code as is and consider this approach for future designs.
Wait, what did you do? get_ram_size(base, max) must work and return CONFIG_SYS_SDRAM_SIZE, or you haven't properly configured your controller (as get_ram_size just pokes parts of the specified range).
- -- Tom