On Thu, Oct 25, 2018 at 5:46 PM Peng Fan peng.fan@nxp.com wrote:
Hi Tim,
-----Original Message----- From: Tim Harvey [mailto:tharvey@gateworks.com] Sent: 2018年10月26日 5:10 To: Anatolij Gustschin agust@denx.de; Peng Fan peng.fan@nxp.com Cc: u-boot u-boot@lists.denx.de; Stefano Babic sbabic@denx.de; Fabio Estevam fabio.estevam@nxp.com Subject: Re: [U-Boot] [PATCH v6 34/34] imx: add i.MX8QXP MEK board support
On Thu, Oct 18, 2018 at 5:52 AM Anatolij Gustschin agust@denx.de wrote:
From: Peng Fan peng.fan@nxp.com
Add i.MX8QXP MEK board support Enabled pinctrl/clk/power-domain/mmc/i2c/fec driver. Added README file.
Signed-off-by: Peng Fan peng.fan@nxp.com Reviewed-by: Anatolij Gustschin agust@denx.de Cc: Stefano Babic sbabic@denx.de Cc: Fabio Estevam fabio.estevam@nxp.com
arch/arm/dts/Makefile | 2 + arch/arm/dts/fsl-imx8qxp-mek.dts | 246
++++++++++++++++++++++
arch/arm/mach-imx/imx8/Kconfig | 13 ++ board/freescale/imx8qxp_mek/Kconfig | 14 ++ board/freescale/imx8qxp_mek/MAINTAINERS | 6 + board/freescale/imx8qxp_mek/Makefile | 7 + board/freescale/imx8qxp_mek/README | 72 +++++++ board/freescale/imx8qxp_mek/imx8qxp_mek.c | 170 +++++++++++++++ board/freescale/mx8mq_evk/README | 81 +++++++
Peng,
Was the inclusion of the mx8mq_evk/README a mistake as this patch was centered around adding support for the i.MX8QXP MEK board?
That file was added by mistaken.
I'm interested in building mainline U-Boot for the NXP i.MX 8M Quad Evaluation Kit (IMX8MQUADEVKQSG) which I assume is what the mx8mq_evk is for. Do you have plans to submit the rest of what's required for this board (configs/mx8mq_evk_defconfig, board/freescale/mx8mq_evk/*, arch/arm/dts/fsl-imx8mq-evk.dts).
It looks like inclusion of imx8mq-evk was was in a patch series early this year and got stalled for some reason?
The ddr script is not good enough for upstream. I have asked help internal to restructure the code, but seems I have to be the guy working on this again.
My current plan is the board support including ddr and mkimage could be ready in next RC1.
Peng,
Ok - thanks for the update. If you remember at the time please cc me on the imx8mq-evk patch series and I will be happy to test.
I read through the discussion regarding the ddr init from your v5 submission (https://patchwork.ozlabs.org/patch/857974/). You mention in that discussion that there is a ddr tool developed by NXP much like the one used for i.MX6/7. I remember using a DDR config tool from Freescale which was a spreadsheet and we ended up writing the ddr init code for imx6 SPL that followed the equations in that spreadsheet along with the ddr init sequence from the IMX6 reference manual. Could this be done here as well?
Can you point me to the NXP DDR tool for IMX8? I'm just getting started with the IMX8M and haven't run into it yet. DDR calibration was a huge pain for us for IMX6.
Also, for your next submission for imx8m-evk please think about the following: - rename mx8mq to imx8mq to be consistent with what you did for imx8qxp_mek - consider adding a flash map to the README showing where imx-mkimage is putting everything in the flash.bin image
I tried to apply your v5 imx8mq-evk patch on top of the latest master but ran into build issues so I'm anxiously awaiting your next submission!
Best Regards,
Tim