-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 10/07/2013 09:55 AM, Wolfgang Denk wrote:
Dear Tom,
In message 20131007121252.GS15917@bill-the-cat you wrote:
331 filename = argv[3]; 332 addr = simple_strtoul(argv[4], NULL, cmdline_base); 333 bytes = simple_strtoul(argv[5], NULL, cmdline_base); 334 if (argc >= 7) 335 pos = simple_strtoul(argv[6], NULL, cmdline_base); 336 else 337 pos = 0;
Should we not perform at least minimal error checking, i. e. verify that no garbage arguments have been passed to that function?
Yes, we ought to. If you don't pass fatwrite the right number of arguments we get data aborts, for example.
Well, this is not a problem here, in do_save():
... 325 if (argc < 6 || argc > 7) 326 return CMD_RET_USAGE; ...
And are you sure of "fatwrite"? This calls do_fat_fswrite(). and here I also see some test:
... 98 if (argc < 5) 99 return cmd_usage(cmdtp); ...
Off-by-one error somewhere? 'mmc' 'part' 'ddr-addr' 'filename' will blowup as we use an insane value for size. I suspect we aren't eating 'fatwrite' somewhere along the line.
- -- Tom