On Wed, Oct 4, 2023 at 8:35 PM egyszeregy@freemail.hu wrote:
From: Benjamin Szőke egyszeregy@freemail.hu
Take over codes from Techenxion to support mmc autodetect boot for pico-imx7d.
Signed-off-by: Benjamin Szőke egyszeregy@freemail.hu
I wanted to test your patch, but there are several issues:
checkpatch complains: total: 5 errors, 7 warnings, 5 checks, 214 lines checked
git am complains:
Applying: pico-imx7d: add baseboard SD card boot detect .git/rebase-apply/patch:41: trailing whitespace. .git/rebase-apply/patch:58: trailing whitespace. .git/rebase-apply/patch:61: trailing whitespace. warning: 3 lines add whitespace errors.
Then when I try to build:
board/technexion/pico-imx7d/pico-imx7d.c: In function ‘board_late_mmc_init’: board/technexion/pico-imx7d/pico-imx7d.c:173:9: warning: implicit declaration of function ‘run_command’ [-Wimplicit-function-declaration] 173 | run_command(cmd, 0); | ^~~~~~~~~~~ board/technexion/pico-imx7d/pico-imx7d.c:150:14: warning: unused variable ‘mmcblk’ [-Wunused-variable] 150 | char mmcblk[32]; | ^~~~~~
board/technexion/pico-imx7d/spl.c: In function ‘board_mmc_init’: board/technexion/pico-imx7d/spl.c:261:33: error: ‘CONFIG_SYS_FSL_USDHC_NUM’ undeclared (first use in this function); did you mean ‘CFG_SYS_FSL_USDHC_NUM’? 261 | for (index = 0; index < CONFIG_SYS_FSL_USDHC_NUM; ++index) { | ^~~~~~~~~~~~~~~~~~~~~~~~ | CFG_SYS_FSL_USDHC_NUM board/technexion/pico-imx7d/spl.c:261:33: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [scripts/Makefile.build:256: spl/board/technexion/pico-imx7d/spl.o] Error 1 make[1]: *** [scripts/Makefile.spl:533: spl/board/technexion/pico-imx7d] Error 2
You clearly haven't tested your patch.