Re: [U-Boot] [PATCH 07/11] sandbox: Add a way of obtaining directory listings

On Wed, Dec 26, 2012 at 11:53:34AM -0800, Simon Glass wrote:

This implementation uses opendir()/readdir() to access the directory information and then puts it in a linked list for the caller's use.

Signed-off-by: Simon Glass sjg@chromium.org

arch/sandbox/cpu/os.c | 101 +++++++++++++++++++++++++++++++++++++++++++++++++ include/os.h | 48 +++++++++++++++++++++++ 2 files changed, 149 insertions(+), 0 deletions(-)

Since the code looks fine,

Reviewed-by: Tom Rini trini@ti.com

But a question. Do you really want this in cpu/os.c rather than some new file for filesystem stuff (since this is the arch side of sandboxfs) ? I can see you saying it should stay here since it's all OS interaction related stuff.