On Thu, 2014-05-01 at 21:28 +0200, Marek Vasut wrote:
On Thursday, May 01, 2014 at 08:40:44 PM, Ian Campbell wrote:
This patch adds the basic clocks and timer support for the Allwinner A20 (sun7i) processor. This code will not been compiled until the build is hooked up in a later patch. It has been split out to keep the patches manageable.
Some of the code here is common to multiple sunxi subarchtectures, hence files are named sun4i which is the earliest similar variant.
Signed-off-by: Alexandru Gagniuc mr.nuke.me@gmail.com Signed-off-by: Chen-Yu Tsai wens@csie.org Signed-off-by: Emilio López emilio@elopez.com.ar Signed-off-by: Hans de Goede hdegoede@redhat.com Signed-off-by: Henrik Nordstrom henrik@henriknordstrom.net Signed-off-by: Jens Kuske jenskuske@gmail.com Signed-off-by: Luke Leighton lkcl@lkcl.net Signed-off-by: Oliver Schinagl oliver@schinagl.nl Signed-off-by: Ian Campbell ijc@hellion.org.uk Cc: Stefan Roese sr@denx.de Cc: Tom Cubie Mr.hipboi@gmail.com
v4: "Based on d9fe0a1e061e "sunxi: mksunxiboot: remove unnecessary casts."
I have no idea what this changelog entry tells me, I will have to review this entire patch anew.
This was mainly for my benefit, so I could track which u-boot-sunxi.git version each commit was most recently sync'd with.
This particular patch needed no changes for the rebasing. I'm going to go through the rest now and reply with a proper v3..v4 changelog. If I don't reply to a particular patch it means nothing much changed.
[...]
+void clock_set_pll1(int hz) +{
int i = 0;int axi, ahb, apb0;struct sunxi_ccm_reg * const ccm =(struct sunxi_ccm_reg *)SUNXI_CCM_BASE;/* Find target frequency */while (pll1_para[i].freq < hz)i++;You can just do a for (...) cycle here, instead of the unbounded while cycle.
it's not unbounded, the array has a sentinal value.
Also, I think hz will always be positive, thus int hz -> unsigned int hz .
Ack.
Ian.