Re: [PATCH v1 02/23] phy: marvell: rename comphy related definitions to COMPHY_XX

On Wednesday 24 March 2021 15:06:28 Stefan Roese wrote:

diff --git a/arch/arm/dts/armada-3720-espressobin.dts b/arch/arm/dts/armada-3720-espressobin.dts index 96a4b3d95b88..3cea5218d2b3 100644 --- a/arch/arm/dts/armada-3720-espressobin.dts +++ b/arch/arm/dts/armada-3720-espressobin.dts @@ -83,18 +83,18 @@ &comphy { max-lanes = <3>; phy0 {

• phy-type = <PHY_TYPE_USB3_HOST0>;
  

• phy-speed = <PHY_SPEED_5G>;
  

• phy-type = <COMPHY_TYPE_PEX0>;
  

• phy-speed = <COMPHY_SPEED_2_5G>;
  

Why you are changing type USB to type PCIe? Possible typo?

};

phy1 {

• phy-type = <PHY_TYPE_PEX0>;
  

• phy-speed = <PHY_SPEED_2_5G>;
  

• phy-type = <COMPHY_TYPE_USB3_HOST0>;
  

• phy-speed = <COMPHY_SPEED_5G>;
  

Same here. PCIe is changed to USB.

};

phy2 {

• phy-type = <PHY_TYPE_SATA0>;
  

• phy-speed = <PHY_SPEED_5G>;
  

• phy-type = <COMPHY_TYPE_SATA0>;
  

• phy-speed = <COMPHY_SPEED_5G>;
  

  };

};