Re: [U-Boot] [PATCH 3/5] miiphyutil: Add Micrel KSZ9021 support to miiphy_speed

On Friday 13 January 2012 07:10:02 Dirk Behme wrote:

common/miiphyutil.c | 18 +++++++++++++++++- 1 files changed, 17 insertions(+), 1 deletions(-)

this is dead code ... i think we're pushing people to use the name phy framework rather than fixing/extending the old one.

--- a/common/miiphyutil.c +++ b/common/miiphyutil.c

+#ifdef CONFIG_PHY_MICREL_KSZ9021 +#define MII_PHY_CTL 0x1f +#define MII_PHY_CTL_1000 (1 << 6) +#define MII_PHY_CTL_100 (1 << 5) +#define MII_PHY_CTL_10 (1 << 4)

are you sure there aren't defines already in linux/mii.h for these ? -mike