On Fri, 28 Jul 2017 21:22:32 +0200 Philipp Tomsich philipp.tomsich@theobroma-systems.com wrote:
With SPL_LDSCRIPT defined via Kconfig, we can run moveconfig... this will touch every configuration that uses SPL, even if there was an implicit resolution of the SPL_LDSCRIPT: now everything is explicit.
Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Changes in v3:
- moveconfig.py CONFIG_SPL_LDSCRIPT (Note: I really don't know whether this is what we want, as it's making the SPL_LDSCRIPT resolution explicit for every board... then again, I understood Tom's comment that moving things into Kconfig should be the priority...)
Changes in v2: None
configs/A10-OLinuXino-Lime_defconfig | 1 +
[...]
include/configs/zynq-common.h | 2 -- 369 files changed, 313 insertions(+), 106 deletions(-)
diff --git a/configs/A10-OLinuXino-Lime_defconfig b/configs/A10-OLinuXino-Lime_defconfig index 9143022..7d45c1d 100644 --- a/configs/A10-OLinuXino-Lime_defconfig +++ b/configs/A10-OLinuXino-Lime_defconfig @@ -11,6 +11,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun4i-a10-olinuxino-lime" CONFIG_AHCI=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y +CONFIG_SPL_LDSCRIPT="arch/arm/cpu/armv7/sunxi/u-boot-spl.lds"
Why do we want to clutter board-specific config files with this information?
If this is migrated to Kconfig, then we probably want to have reasonable SoC-specific defaults there and leave defconfigs alone.
CONFIG_SPL_I2C_SUPPORT=y # CONFIG_CMD_IMLS is not set # CONFIG_CMD_FLASH is not set