On 20/05/2023 00.26, Adam Ford wrote:
On Fri, May 19, 2023 at 5:19 PM Tim Harvey tharvey@gateworks.com wrote:
On Wed, May 3, 2023 at 9:11 AM Tim Harvey tharvey@gateworks.com wrote:
Fabio,
Apparently I didn't do a very good job of testing this. This patch is causing imx8mp-venice-* and imx8mp-evk boards to no longer boot with no SPL banner. The specific change that causes breakage is the one that encapsulates the spi/uart/flexcan children with spba-bus@30800000.
The SPI, UART, and Flexcan are part of the spba-bus.
We'll need to add the spba bus to imx8mp-u-boot.dtsi. Since it had no node name, it'll have to fall under aip3.
Try this:
diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8mp-u-boot.dtsi index 18d1728e1d..0e6811b129 100644 --- a/arch/arm/dts/imx8mp-u-boot.dtsi +++ b/arch/arm/dts/imx8mp-u-boot.dtsi @@ -44,6 +44,10 @@
&aips3 { bootph-pre-ram;
spba-bus@30800000 {bootph-pre-ram;};};
&iomuxc {
This begs the question: Why don't these tags just implicitly propagate to parent nodes? It's a U-Boot specific tool (fdtgrep) that makes use of them, no? So making the rule be "keep this node if it _or any descendant_ has that tag" should be possible.
This has probably been answered somewhere before.
Rasmus