
22 Jan
2010
22 Jan
'10
1:53 p.m.
Dear Stefan Roese,
In message 1264162912-21791-1-git-send-email-sr@denx.de you wrote:
A newer CPLD version on the 405EX evaluation board requires a different EBC controller setup for the CPLD register access. This patch now adds a CPLD version detection for Kilauea and code to reconfigure the EBC controller (chip select 2) for the new CPLD.
I think the comment shouldbe changed to match the code, i. e. something like this:
... This patch adds a CPLD version detection for Kilauea and code to reconfigure the EBC controller (chip select 2) for the old CPLD if no new version is found.
Except for that: Acked-by: Wolfgang Denk wd@denx.de
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
All a hacker needs is a tight PUSHJ, a loose pair of UUOs, and a warm
place to shift.