On Thu, Aug 30, 2018 at 12:44:00AM -0300, Ezequiel Garcia wrote:
On 30 August 2018 at 00:00, Manivannan Sadhasivam manivannan.sadhasivam@linaro.org wrote:
Hi Ezequiel,
On Wed, Aug 29, 2018 at 03:11:17AM -0300, Ezequiel Garcia wrote:
Hi Manivannan,
On 21 August 2018 at 14:09, Manivannan Sadhasivam manivannan.sadhasivam@linaro.org wrote:
This patchset adds board support for Vamrs Limited Rock960, which is one of the 96Boards Consumer Edition platform based on Rockchip RK3399 SoC.
What are the differences between this consumer edition board, and the enterprise edition (aka Ficus) Vamrs board?
I asked Vamrs about this and they said the difference is very minimal.
In that case, you should try to leverage the Linux ficus.dts:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch...
If no differences, using the ficus dts should do. If there are differences, we can create a common rock960.dtsi and then enterprise and consumer edition dts.
Okay. Here are the differences between Ficus and Rock960 CE:
- Different host enable GPIO for USB (vcc5v0_host)
- Different power and reset for PCI-E (vcc3v3_pcie, pcie0)
- No Ethernet port on Rock960 (gmac)
So, I would suggest keeping USB, PCI-E and GMAC related nodes on the board specific devicetree and rest on the rk3399-rock960.dtsi. What do you think?
Same applies to Linux also!
Yes, I think a rk3399-rock960.dtsi with the differences in two .dts would be great, and even better a single U-Boot which can detect the board and load the right DT, but I do think it should be a separate config to evb as Mani mentioned.
Peter