Re: [U-Boot] [PATCH v2 1/6] board_f: Drop the timer after relocation

Hi Simon,

On Sun, Aug 27, 2017 at 11:23 PM, Simon Glass sjg@chromium.org wrote:

Once U-Boot relocates itself the existing driver-model timer (if any) is no-longer valid until the device is reinitialised. Any use of the device may cause a crash. To handle this, set the timer to NULL after relocation.

Signed-off-by: Simon Glass sjg@chromium.org

Changes in v2: None

common/board_f.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/common/board_f.c b/common/board_f.c index 104d144f41a..2e597ddf99f 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -952,6 +952,7 @@ void board_init_f_r(void) * UART if available. */ gd->flags &= ~GD_FLG_SERIAL_READY;

•   gd->timer = NULL;
  

This needs to be wrapped with #ifdef CONFIG_TIMER.

    /*
     * U-Boot has been copied into SDRAM, the BSS has been cleared etc.

--

Regards, Bin