Hi Stephen,
On Sat, 09 Mar 2013 23:34:21 -0700, Stephen Warren swarren@wwwdotorg.org wrote:
On 02/03/2013 04:27 AM, Albert ARIBAUD wrote:
On Tue, 15 Jan 2013 19:26:58 -0700, Stephen Warren swarren@wwwdotorg.org wrote:
This adds a simple driver for the BCM2835's SD controller.
Workarounds are implemented for:
- Register writes can't be too close to each-other in time, or they will be lost.
- Register accesses must all be 32-bit, so implement custom accessors.
This code was extracted from: git://github.com/gonzoua/u-boot-pi.git master which was created by Oleksandr Tymoshenko.
Portions of the code there were obviously based on the Linux kernel at: git://github.com/raspberrypi/linux.git rpi-3.6.y commit f5b930b "Main bcm2708 linux port" signed-off-by Dom Cobley.
swarren changed the following for upstream:
- Removed hack udelay()s in bcm2835_sdhci_raw_writel(); setting SDHCI_QUIRK_WAIT_SEND_CMD appears to solve the issues.
- Remove register logging from read*/write* functions.
- Sort out confusion with min/max_freq values passed to add_sdhci().
- Use more descriptive variable names and calculations in IO accessors.
- Simplified and commented twoticks_delay calculation.
- checkpatch fixes.
Cc: Andy Fleming afleming@gmail.com Signed-off-by: Oleksandr Tymoshenko gonzo@bluezbox.com Signed-off-by: Stephen Warren swarren@wwwdotorg.org
Andy, could you please ack this so Albert can take it through the ARM tree; patch 7/7 depends is an ARM patch and depends on this. Thanks.
...
Andy, can you give a formal Acked-By to this patch as per Stephen's request?
Thanks in advance!
Albert, it looks like Andy actually did already Ack this, back in November last year; see:
http://lists.denx.de/pipermail/u-boot/2012-November/141064.html
Note that when I reposted V5 in January, I merged the ARM/mailbox/video patches and MMC series together, hence the different patch numbers.
Are you OK pulling this series out of patchwork to be applied, or should I repost? Thanks.
I'll apply the series from patchwork to u-boot-arm/master, adding Andy's Ack manually in 6/7. If these apply cleanly, then all right.
Amicalement,