Re: [U-Boot] [PATCH v3 011/108] i2c: Tidy up designware PCI support

Hello Simon,

Am 21.10.2019 um 05:31 schrieb Simon Glass:

This is hacked into the driver at present. It seems better to have it as a separate driver that uses the base driver. Create a new file and put the X86 code into it.

Actually the Baytrail settings should really come from the device tree.

Signed-off-by: Simon Glass sjg@chromium.org

Changes in v3: None Changes in v2: None

drivers/i2c/Makefile | 3 + drivers/i2c/designware_i2c.c | 104 ++++++----------------------------- drivers/i2c/designware_i2c.h | 35 ++++++++++++ drivers/i2c/dw_i2c_pci.c | 78 ++++++++++++++++++++++++++ 4 files changed, 132 insertions(+), 88 deletions(-) create mode 100644 drivers/i2c/dw_i2c_pci.c

Reviewed-by: Heiko Schocher hs@denx.de

Thanks!

bye, Heiko