On Thu, Nov 16, 2023 at 10:57:27AM +0000, Marcel Ziswiler wrote:
Hi Tom
On Thu, 2023-11-02 at 08:09 +0100, Marcel Ziswiler wrote:
Hi Stefano
On Thu, 2023-10-26 at 10:36 +0200, Stefano Babic wrote:
On 26.10.23 10:29, Rasmus Villemoes wrote:
On 26/10/2023 09.32, Marcel Ziswiler wrote:
From: Marcel Ziswiler marcel.ziswiler@toradex.com
This fixes a regression in the eMMC fast boot mode case where the buffer was missing 464 bytes.
The code figures out how many bytes must at least be fetched to honor the current read, rounds that up to the ss->pagesize [which is a no-op in the USB download case because that has ->pagesize==1], fetches that many bytes, but then recorded the original upper bound as the new end of the valid data. However, this did not take into account the rounding up to the ss->pagesize. Fix this by recording the actual bytes downloaded.
Fixes: 4b4472438f5a ("imx: spl_imx_romapi: avoid tricky use of spl_load_simple_fit() to get full FIT size") Signed-off-by: Marcel Ziswiler marcel.ziswiler@toradex.com
Thanks for reporting and fixing this, and sorry for the trouble.
Acked-by: Rasmus Villemoes rasmus.villemoes@prevas.dk
And thanks for all your work - I will apply this fix soon.
Any news on applying this fix? Note that master still stays broken as of today.
And two weeks later still broken!
I've put this in my not to forget queue for the next -rc.
Anyway, I feel i.MX maintainership seems rather stalled at times most of the time. I don't want to criticise anybody knowing how busy our trade can get. However, if it helps the cause Toradex would be ready to step up. Let me know what you think. Thanks!
I would be happy to see an additional custodian for the imx tree, if that's agreeable with Stefano.