Hi Otavio,
On Wed, Jan 23, 2013 at 10:53 AM, Otavio Salvador otavio@ossystems.com.br wrote:
The following features are supported:
- 128 MB DDR1 SDRAM
- SD/MMC Card Socket
DUART as well.
/* AUART */MX23_PAD_AUART1_RX__AUART1_RX | MXS_PAD_CTRL,MX23_PAD_AUART1_TX__AUART1_TX | MXS_PAD_CTRL,MX23_PAD_AUART1_CTS__AUART1_CTS | MXS_PAD_CTRL,MX23_PAD_AUART1_RTS__AUART1_RTS | MXS_PAD_CTRL,
I don't think we use AUART in U-boot, so just remove it.
--- /dev/null +++ b/include/configs/mx23evk.h @@ -0,0 +1,250 @@ +/*
- Freescale i.MX23 CLKCTRL Register Definitions
This comment does not apply here.
+/*
- SoC configurations
- */
I know this format is used in some other config files, but do we really need multi-line style for a single line comment?
Why not just:
/* SoC configurations */ , instead?
Same applies to other comments throughout this file.
+/*
- U-Boot general configurations
- */
+#define CONFIG_SYS_LONGHELP +#define CONFIG_SYS_PROMPT "MX23EVK U-Boot > "
What about just " =>" as the prompt?
+/*
- RTC
- */
+#ifdef CONFIG_CMD_DATE +#define CONFIG_RTC_MXS +#endif
Has RTC been tested on mx23? If not, please remove it.
+/*
- USB
- */
+#ifdef CONFIG_CMD_USB +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_MXS +#define CONFIG_EHCI_MXS_PORT 1 +#define CONFIG_EHCI_IS_TDI +#define CONFIG_USB_STORAGE +#endif
Has USB been tested on mx23? If not, please remove it.
+/*
- SPI
- */
+#ifdef CONFIG_CMD_SPI +#define CONFIG_HARD_SPI +#define CONFIG_MXS_SPI +#define CONFIG_SPI_HALF_DUPLEX +#define CONFIG_DEFAULT_SPI_BUS 2 +#define CONFIG_DEFAULT_SPI_MODE SPI_MODE_0 +#endif
Has SPI been tested on mx23? If not, please remove it.
Regards,
Fabio Estevam