Re: [U-Boot] [PATCH 2/2] Makefile: Accept target names in all lower case to ease matching

Dear Henrik Nordström,

In message 1353866899.28559.57.camel@home.hno.se you wrote:

...

...

@awk '(NF && $$1 !~ /^#/) { print $$1 ": " $$1 "_config; $$(MAKE)" }' $< > $@

• @awk '(NF && $$1 !~ /^#/ && tolower($$1) != $$1) { print tolower($$1) ": " $$1 "_config; $$(MAKE)" }' $< > $@

NAK. This is not DOS. Names are case sensitive.

Ok, then I'll swing the patch in the other direction and make target names actually case sensitive. Because today they are a bit confused partially case-insensitive.

Where exactly?

Note that it's not about board config file names or directory names, only about the first column in boards.cfg.

Well, these are make targets, so they are definitely case sensitive.

if [ ( $# -eq 2 ) -a ( "$1" = "-A" ) ] ; then # Automatic mode

• line=`egrep -i "^[[:space:]]*${2}[[:space:]]" boards.cfg` || {

• line=`egrep "^[[:space:]]*${2}[[:space:]]" boards.cfg` || {

Did you test what gets broken by this patch?

Best regards,

Wolfgang Denk