On 06/21/2018 05:20 PM, Tom Rini wrote:
On Thu, Jun 21, 2018 at 05:11:27PM +0200, Alexander Graf wrote:
On 06/19/2018 08:41 PM, Tom Rini wrote:
On Fri, Jun 08, 2018 at 08:53:26PM +0300, Ramon Fried wrote:
Add dump trace command which dump all trace buffer content in a much more readable fashion than md.
Signed-off-by: Ramon Fried ramon.fried@gmail.com Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot/master, thanks!
This fails to compile for me:
cmd/iotrace.c: In function ‘do_print_trace’: cmd/iotrace.c:42:2: error: ‘for’ loop initial declarations are only allowed in C99 mode for (int i = 0; i < count; i++) { ^ cmd/iotrace.c:42:2: note: use option -std=c99 or -std=gnu99 to compile your code scripts/Makefile.build:278: recipe for target 'cmd/iotrace.o' failed
Yes. I didn't notice this part in time, and I've posted a patch to start using -std=gnu11 globally as that makes more sense to me than reworking this (and a few other ARM-specific areas) that make use of this construct.
Wouldn't it make more sense to fix this place up for now and postpone the -std=gnu11 patch for post-release?
Alex