
On Sat, 13 Apr 2019, Chris Packham wrote:
On Sat, 13 Apr 2019, 4:56 AM Robert P. J. Day, rpjday@crashcourse.ca wrote: one of the worst culprits appears to be CONFIG_SPL_BUILD, which appears all over the tree, but one can see a recent commit that takes that into account:
That's not quite right. CONFIG_SPL_BUILD is defined for the Makefile just not in Kconfig (I'm on a tablet right now so I can't point you to the source).
commit 0ef692084363f2de8547db93397c6a69123d26ca Author: Baruch Siach <baruch@tkos.co.il> Date: Thu Feb 7 13:21:16 2019 +0200 Kconfig: fix BUILD_TARGET for ARCH_MVEBU Commit dc146ca11187 ("Kconfig: Migrate CONFIG_BUILD_TARGET") made the mvebu default build target depend on CONFIG_SPL_BUILD. Unfortunately, there is no such Kconfig symbol. Use the CONFIG_SPL symbol instead to fix that. Cc: Jagan Teki <jagan@amarulasolutions.com> Signed-off-by: Baruch Siach <baruch@tkos.co.il> Reviewed-by: Stefan Roese <sr@denx.de> Reviewed-by: Jagan Teki <jagan@amarulasolutions.com> Signed-off-by: Stefan Roese <sr@denx.de>
This commit addresses the fact that CONFIG_SPL_BUILD is not available to use in Kconfig. It is available to Makefiles, I can't remember if it gets defined for source files.
i realize there are such things; however, the standard is that any options/variables prefixed with "CONFIG_" are typically defined as part of the Kbuild infrastructure (with the exception of prefixes of "CONFIG_SYS_").
i think what you're referring to is in scripts/Makefile.spl:
scripts/Makefile.spl:KBUILD_CPPFLAGS += -DCONFIG_SPL_BUILD
i'm not going to make recommendations one way or the other; merely pointing out that i have scripts that display such things, and people are free to do what they wish with the results.
rday