On 14.07.17 15:47, Simon Glass wrote:
Hi,
On 3 July 2017 at 06:21, Alexander Graf agraf@suse.de wrote:
On 06/25/2017 10:56 PM, Heinrich Schuchardt wrote:
Currenty any EFI status other than EFI_SUCCESS is reported as Application terminated, r = -22
With the patch the status code and its mnemonic is printed.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
While I think it's very useful to have the status code, I don't want to waste 1kb of .rodata on every binary out there - that will only drive more people to disable CONFIG_EFI_LOADER which is the opposite of what we want.
Can you please respin without the string return for now? Maybe we can add a CONFIG_EFI_LOADER_DEBUG option later on which gives us verbose printing on demand on a few more bits.
I think the error messages are useful and would like to see this new option. Bonus points if they can be in lower case :-)
Yeah, thinking about it again, we can even add the string conversion as is but not call it if DEBUG_EFI is not set ;).
And yes, I would really prefer to make all the debugging facilities here slightly more fine grained and smarter.
Alex