Re: [U-Boot] [PATCH] Davinci: Configurable NAND chip selects

Dear Scott Wood,

In message 20091118202216.GA15517@loki.buserror.net you wrote:

On Mon, Nov 16, 2009 at 05:49:55PM +0000, Nick Thompson wrote:

...

static void nand_davinci_enable_hwecc(struct mtd_info *mtd, int mode) {

• int dummy;

• u_int32_t val;

• dummy = emif_regs->NANDF1ECC;

• val = readl(&emif_regs->NANDF1ECC);

"val =" can be omitted, which would keep it clear that it is a dummy read.

For a little more emphasis one can even write

(void)readl(&emif_regs->NANDF1ECC);

which really makes it clear that the return value is ignored intentionally.

Best regards,

Wolfgang Denk