On 2/19/23 13:48, Elmar Psilog wrote:
Without that patch it lost track to the node to scan speed and duplex. Patch was created by Marek Vasut, just tested by me.
Signed-off-by: Elmar Psilog <epsi at gmx.de>
changes v2: fix format issues
drivers/net/dwc_eth_qos.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index 112deb546d..ff638b0f1e 100644 --- a/drivers/net/dwc_eth_qos.c +++ b/drivers/net/dwc_eth_qos.c @@ -788,9 +788,22 @@ static int eqos_start(struct udevice *dev) */ if (!eqos->phy) { int addr = -1;
addr = eqos_get_phy_addr(eqos, dev);eqos->phy = phy_connect(eqos->mii, addr, dev,eqos->config->interface(dev));
ofnode fixed_node;if (IS_ENABLED(CONFIG_PHY_FIXED)) {fixed_node = ofnode_find_subnode(dev_ofnode(dev),"fixed-link");if (ofnode_valid(fixed_node)) {eqos->phy = fixed_phy_create(dev_ofnode(dev));}
One more nitpick. Drop the curly brackets {} around this statement, i.e. keep only:
if (ofnode_valid(fixed_node)) eqos->phy = fixed_phy_create(dev_ofnode(dev));
With that fixed in V3, add:
Reviewed-by: Marek Vasut marex@denx.de
Thanks !