Dear Jim Lin,
-----Original Message----- From: Marek Vasut [mailto:marek.vasut@gmail.com] Sent: Monday, July 30, 2012 8:02 PM To: Jim Lin Cc: Wolfgang Denk; Tom Warren; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 1/1] USB: EHCI: Initialize multiple USB controllers at once
Dear Jim Lin,
-----Original Message----- From: Marek Vasut [mailto:marek.vasut@gmail.com] Sent: Friday, July 27, 2012 5:26 PM To: u-boot@lists.denx.de Cc: Jim Lin; Wolfgang Denk; Tom Warren Subject: Re: [U-Boot] [PATCH 1/1] USB: EHCI: Initialize multiple USB controllers at once
Wolfgang, Is there any chance to get this feature in after Stephen explained to you?
I'll poke into it. Can we not get rid of the added ifdef, eg. by setting up the controller number to 1 for those that don't define CONFIG_USB_MULTI now (everyone)
I assume you want me to add these in next patch. 1 . Use CONFIG_USB_MULTI, instead of CONFIG_USB_INIT_MULTI
(current patch),
- If CONFIG_USB_MULTI is not defined, then define
CONFIG_USB_MAX_CONTROLLER_COUNT as 1.
Yes, is that a problem? Aka. have this always enabled and don't treat not having multiple controllers as a special case.
Item 2 is not necessary. Because CONFIG_USB_MAX_CONTROLLER_COUNT will not be used if CONFIG_USB_MULTI is not defined.
But we don't need CONFIG_USB_MULTI option at all -- just assume it's always defined and unless a board has multiple controllers, define CONFIG_USB_MAX_CONTROLLER_COUNT to be 1.
Aka. it boils down to sticking
#ifndef CONFIG_USB_MAX_CONTROLLER_COUNT #define CONFIG_USB_MAX_CONTROLLER_COUNT 1 #endif
somewhere in usb.c or so.
Best regards, Marek Vasut