Hi Wolfgang,
On Thu, Mar 8, 2012 at 4:13 PM, Wolfgang Denk wd@denx.de wrote:
Dear Lei Wen,
In message CALZhoSSk3D9UY48ND_6HdZX1N_gP3rq0LP4w1e1M5bp3brzN9Q@mail.gmail.com you wrote:
I wonder which benefits we get for this price we are paying?
The main reason I'd like to introduce this upgrade is for I want to add the compressing feature for uboot.
This should be make optional code, including any extensions / additional functions that may be needed for zlib.
Most users will not need this, and they should not suffer (in terms of increased memory footprint) from such a change.
And the 1.2.6 has some fix for the deflate, so it is maybe a good base line for introducing it.
Which exact fix are you referring to?
I am referring to the zlib 1.2.5->1.2.6 changelog: Added deflatePending() to return the amount of pending output Allow deflateSetDictionary() and inflateSetDictionary() at any time in raw mode deflatePrime() can now insert bits in the middle of the stream
How about define a Macro like CONIFG_ENABLE_GZIP_COMPRESSION to compile the compression related code only when this flag is on?
This makes sense, but please use standard naming rules. You will probably provide a "zip" command, so make all this depend on "CONFIG_CMD_ZIP" or so.
Yep, that is also what I am thinking.
Best regards,
Wolfgang Denk
Thanks, Lei