Dear Ilya,
In message 1242777361-6717-8-git-send-email-yanok@emcraft.com you wrote:
This patch adds support for i.MX27-LITEKIT development board from LogicPD. This board uses i.MX27 SoC and has 2MB NOR flash, 64MB NAND flash, FEC ethernet controller integrated into i.MX27.
Signed-off-by: Ilya Yanok yanok@emcraft.com
MAKEALL | 1 + Makefile | 3 + board/logicpd/imx27lite/Makefile | 51 +++++++ board/logicpd/imx27lite/config.mk | 1 + board/logicpd/imx27lite/imx27lite.c | 97 +++++++++++++ board/logicpd/imx27lite/lowlevel_init.S | 223 +++++++++++++++++++++++++++++++ board/logicpd/imx27lite/u-boot.lds | 56 ++++++++ include/configs/imx27lite.h | 193 ++++++++++++++++++++++++++ 8 files changed, 625 insertions(+), 0 deletions(-) create mode 100644 board/logicpd/imx27lite/Makefile create mode 100644 board/logicpd/imx27lite/config.mk create mode 100644 board/logicpd/imx27lite/imx27lite.c create mode 100644 board/logicpd/imx27lite/lowlevel_init.S create mode 100644 board/logicpd/imx27lite/u-boot.lds create mode 100644 include/configs/imx27lite.h
Entry into the MAINTAINERS file missing.
diff --git a/include/configs/imx27lite.h b/include/configs/imx27lite.h new file mode 100644 index 0000000..d71ac4b --- /dev/null +++ b/include/configs/imx27lite.h
...
+/*
- JFFS2 partitions
- */
These are generic MTD partitions, not restricted to JFFS2.
+#define CONFIG_CMD_MTDPARTS +#define MTDIDS_DEFAULT "nor0=physmap-flash.0,nand0=mxc_nand.0" +#define MTDPARTS_DEFAULT \
- "mtdparts=physmap-flash.0:256k(U-Boot),-(user),64k(env1)," \
- "64k(env2);mxc_nand.0:-(nand)"
It seems this has never been tested. I get:
=> mtdparts mtdparts variable not set, see 'help mtdparts' no partitions defined
defaults: mtdids : nor0=physmap-flash.0,nand0=mxc_nand.0 mtdparts: mtdparts=physmap-flash.0:256k(U-Boot),-(user),64k(env1),64k(env2);mxc_nand.0:-(nand) => mtdparts default no partitions allowed after a fill-up partition
Please fix.
Best regards,
Wolfgang Denk