On 5/22/08 8:27 AM, Stefan Roese wrote:
On Wednesday 21 May 2008, Grant Erickson wrote:
Thanks a lot for all this work. Please find some comments below.
And thank you for your helpful pointers along the way.
diff --git a/board/amcc/kilauea/init.S b/board/amcc/kilauea/init.S index 053fe19..bf47d6b 100644 --- a/board/amcc/kilauea/init.S +++ b/board/amcc/kilauea/init.S
...
Why do we now still have the SDRAM setup for Kilauea included in assembler? Is it because of the NAND booting support? If yes, then leave it as is and I'll clean this up later.
Precisely. You have better exposure and visibility to the subtle nuances of NAND booting on Kilauea, so wrapping up that particular issue is best left to your experience.
diff --git a/board/amcc/kilauea/memory.c b/board/amcc/kilauea/memory.c index 1d7a3fa..b7e2344 100644 --- a/board/amcc/kilauea/memory.c +++ b/board/amcc/kilauea/memory.c
...
diff --git a/board/amcc/makalu/memory.c b/board/amcc/makalu/memory.c index b03b60b..326feb7 100644 --- a/board/amcc/makalu/memory.c +++ b/board/amcc/makalu/memory.c
...
Please remove this file completely. It's not needed anymore, since we now use the common DDR2 controller init code you introduced with this patch. Please remove the testdram() function completely and move the sdram_init() to makalu.c.
For both Kilauea and Makalu or just Makalu and you'll address Kilauea in the course of handling init.S?
Regards,
Grant