Dear Wolfgang Denk,
Dear Marek Vasut,
btw - there is no need to full-quote.
In message 201203122308.54249.marex@denx.de you wrote:
I have but a few formal questions / issues.
I had a dilemma about the image.[ch] indeed. I was quite unsure where to put those, can you suggest proper location? I didn't want to create new file only for that matter.
Sorry, I have no good idea either.
If you omit comment header and includes, common/cmd_bootz.c adds less than 10% to common/cmd_bootm.c - unless we extrace more common code from other boot* commands, you might even add it to cmd_bootm.c (with #ifdef's).
While we are at it:
- zi = (struct zimage_header *)images->ep;
- if (zi->zi_magic != LINUX_ARM_ZIMAGE_MAGIC) {
This gave me an idea ... this might be how to check for zImage inside bootm and be done with it. Simply squash those two together.
Do we have to care about endianess here?
We should make bootz arm-specific until more people (with different arches) step up and verify it works for them.
Best regards,
Wolfgang Denk
Best regards, Marek Vasut