Re: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file

On Mon, Sep 5, 2011 at 12:40 PM, Marek Vasut marek.vasut@gmail.com wrote: ...

...

./scripts/checkpatch.pl -F u-boot/board/karo/tx25/tx25.c .... WARNING: externs should be avoided in .c files #144: FILE: home/fabio/denx/u-boot/board/karo/tx25/tx25.c:144:

• extern void mx25_uart1_init_pins(void);

But you're using extern in _header_ (.h) file ... so ... why ?

My patch removes the extern from the C file and put it on a header file with other extern's.

The checkpatch warning I showed happens with the original file, and not after my patch is applied.