Hi Stephen,
Am Dienstag, den 07.08.2012, 11:09 -0600 schrieb Stephen Warren:
On 08/06/2012 07:18 PM, Lucas Stach wrote:
Most boards don't need this fixup hook. To avoid a lot of empty implementations in board files convert it to a weak symbol.
This seems OK on the surface, but I think there may be more opportunity for cleanup here.
I looked a bit deeper into this and it seems that in fact the logic of all those calls are correct and none them could be removed.
To clarify what's going on: if we are building without CONFIG_SPI_UART_SWITCH the board file has to provide a function gpio_config_uart() to ensure correct GPIO setting and it's correct to call this in early_init.
Now, if we build with CONFIG_SPI_UART_SWITCH set, the board file stops providing the gpio_config_uart() and the UART switch provides a gpio_early_init_uart() function which does essentially the same, so we call this instead in early init.
The confusing part is that the UART switch now provides a function also named gpio_config_uart(), which redoes the GPIO setting after relocation and does some internal state setting.
Now while explaining all this in this email I see how we should make this more clear with some reasonable renaming, but we won't get around the weak symbol if we want to keep the possibility for boards to build without CONFIG_SPI_UART_SWITCH. I'll spin a new patch to untangle this mess a bit.
Thanks, Lucas
In board/nvidia/common/board.c, I see both of the following:
board_init:
#ifdef CONFIG_SPI_UART_SWITCH gpio_config_uart(); #endif
board_early_init_f:
/* Initialize periph GPIOs */ gpio_early_init();#ifdef CONFIG_SPI_UART_SWITCH gpio_early_init_uart(); #else gpio_config_uart(); #endif
and in arch/arm/cpu/arm720t/tegra20/spl.c:
board_init_f:
#ifdef CONFIG_SPI_UART_SWITCH gpio_early_init_uart(); #else gpio_config_uart(); #endif
It sure seems like we don't need to call those two init function all those times. Perhaps we can clarify which of the functions are actually needed at all, and when they should be called.