Hi Simon,
On Fri, Nov 27, 2015 at 10:51 AM, Simon Glass sjg@chromium.org wrote:
The function comments use an old style and some are incorrect. Update them.
Signed-off-by: Simon Glass sjg@chromium.org Reviewed-by: Bin Meng bmeng.cn@gmail.com
Changes in v3:
- Use 'Show' instead of 'Shows' in the the pci_header_show() function comment
Changes in v2:
- Add a new patch to update the function comments
common/cmd_pci.c | 84 ++++++++++++++++++++++++++------------------------------ 1 file changed, 39 insertions(+), 45 deletions(-)
diff --git a/common/cmd_pci.c b/common/cmd_pci.c index f8faa31..7fdd3d8 100644 --- a/common/cmd_pci.c +++ b/common/cmd_pci.c @@ -161,15 +161,10 @@ static struct pci_reg_info regs_cardbus[] = { {}, };
-/*
- Subroutine: PCI_Header_Show
- Description: Reads the header of the specified PCI device.
- Inputs: BusDevFunc Bus+Device+Function number
- Return: None
+/**
- @pci_header_show() - Show the header of the specified PCI device.
nits: please remove @ before pci_header_show(). Sorry I missed this in previous review. Please fix it when applying.
*/
- @dev: Bus+Device+Function number
void pci_header_show(pci_dev_t dev) { @@ -200,16 +195,12 @@ void pci_header_show(pci_dev_t dev) } }
[snip]
Regards, Bin