Re: [U-Boot] [PATCH] mmc-uclass: correct the device number

Hi Kever,

On 18 July 2016 at 03:52, Kever Yang kever.yang@rock-chips.com wrote:

The devnum in is start from 0, so the device number should be (devnum+1).

Signed-off-by: Kever Yang kever.yang@rock-chips.com

drivers/mmc/mmc-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c index 38ced41..7c40d24 100644 --- a/drivers/mmc/mmc-uclass.c +++ b/drivers/mmc/mmc-uclass.c @@ -111,7 +111,7 @@ struct mmc *find_mmc_device(int dev_num)

int get_mmc_num(void) {

•   return max(blk_find_max_devnum(IF_TYPE_MMC), 0);
  

•   return max((blk_find_max_devnum(IF_TYPE_MMC)+1), 0);
  

Please add spaces around the +

Also can you add a comment to the function in mmc.h describing what it should do? From what you are saying it should return the number of mmc devices.

Also you will need to adjust mmc_get_next_devnum() which uses this function.

}

int mmc_get_next_devnum(void)

1.9.1

Regards, Simon