On 4/17/23 20:26, Ralph Siemsen wrote:
On Mon, Apr 17, 2023 at 07:04:15PM +0200, Marek Vasut wrote:
On 3/8/23 21:26, Ralph Siemsen wrote:
Commit 2564fce7eea3 ("sunxi: move Cortex SMPEN setting into start.S") added SPL_ARMV7_SET_CORTEX_SMPEN to enable setting SMP bit. For platforms not using SPL boot, add the corresponding non-SPL config, so that CONFIG_IS_ENABLED(ARMV7_SET_CORTEX_SMPEN) works as expected.
Signed-off-by: Ralph Siemsen ralph.siemsen@linaro.org
Reviewed-by: Marek Vasut marek.vasut+renesas@mailbox.org
You could send this patch as a separate one.
In fact I did that almost a year ago: https://lore.kernel.org/u-boot/20220421175202.2614945-1-ralph.siemsen@linaro...
Hmmm, Tom (+Cc) pointed out the patch does not do anything, but that is not correct, is it ? If I look at 2564fce7eea3 ("sunxi: move Cortex SMPEN setting into start.S") , this extra Kconfig symbol just makes that functionality available outside of SPL (i.e. in normal U-Boot), while before this change the functionality was only available in SPL. Right ?
(so yeah, I think this patch should go in, and could go in separately)
But please correct me if I'm wrong.