Hi Simon, On Thu, Nov 26, 2015 at 06:51:58PM -0800, Simon Glass wrote:
Hi Peng,
On 25 November 2015 at 01:16, Peng Fan Peng.Fan@freescale.com wrote:
"enable" is unsigned char type and its value will not be negative, so discard "enable < 0".
Signed-off-by: Peng Fan Peng.Fan@freescale.com Cc: Diego Santa Cruz Diego.SantaCruz@spinetix.com Cc: Pantelis Antoniou pantelis.antoniou@konsulko.com Cc: Andrew Gabbasov andrew_gabbasov@mentor.com Cc: Simon Glass sjg@chromium.org Cc: Stefano Babic sbabic@denx.de Cc: Tom Rini trini@konsulko.com
common/cmd_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Even better if this variable changed to uint, instead of u8.
Thanks for reviewing, But I prefer to let it be, since mmc_set_rst_n_function takes u8 type for input parameter.
Thanks, Peng.
Regards, Simon
--