On Saturday 28 April 2012 23:32:25 Wolfgang Denk wrote:
Please stop sending base64 encoded patches! Send plain text only!
I used git format-patch and git send-email. Is there easy way how to tell this to git?
While it is a good idea to provide documentation, this is the wrong place for it. Here in the commit message is about the last place where most of the users will search for it. Please provide a README for this board - either in the board directory, or in doc/
Is doc/README.nokia_rx51 correct place?
BUt also keep in mind that this is a maintenance problem - who will make sure that this documentation gets updated when someone changes to code?
board/nokia/rx51/Makefile | 46 +++++ board/nokia/rx51/lowlevel_init.S | 71 +++++++ board/nokia/rx51/rx51.c | 380 ++++++++++++++++++++++++++++++++++++++ board/nokia/rx51/rx51.h | 378 +++++++++++++++++++++++++++++++++++++ boards.cfg | 1 + include/configs/nokia_rx51.h | 373 +++++++++++++++++++++++++++++++++++++ 6 files changed, 1249 insertions(+) create mode 100644 board/nokia/rx51/Makefile create mode 100644 board/nokia/rx51/lowlevel_init.S create mode 100644 board/nokia/rx51/rx51.c create mode 100644 board/nokia/rx51/rx51.h create mode 100644 include/configs/nokia_rx51.h
Entry in MAINTAINERS missing.
Ok, I will add myself to MAINTAINERS.
+/*
- Size of malloc() pool
- */
+#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB
Sector */
+#define CONFIG_UBI_SIZE (512 << 10) /* 512 KiB
Sector */
+#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + CONFIG_UBI_SIZE + \ + (128 << 10))
Comment appears to be misplaced.
Ok, comment will be removed.
+/* Maemo kernel 2.6.28 will crash if u-boot enable usb tty */ +/* +#define CONFIG_USB_TTY +*/
Please remove dead code.
usb tty is usefull for debuging u-boot. because this device does not have easy access to serial console, usb tty is only option how to connect u-boot terminal to pc. but default (and still only one working on this device) kernel crash when u-boot enable usb tty. I want to have usb tty option in u-boot and belive that one day will be some upstream linux kernel with fixed usb drivers working on nokia n900.
+/* OneNand support is disabled, because U-Boot image is too big */ +/* Uncomment next line to enable it */ +/* #define ONENAND_SUPPORT */
Incorrect multiline comment / please remove dead code.
How to write correct comment?
Also onenand code working fine, but when is enabled u-boot binary is too big and cannot be flashed into this device. But for testing in qemu or booting u-boot with enabled onenand support stored in mmc via flashed u-boot (with disabled onenand support) working too.
Is there way how to decrease u-boot binary size?
Best regards,
Wolfgang Denk