Wolfgang Denk wrote:
Dear Kim,
I would like to suggest to clean up the output printed by most MPC83xx boards a bit. What do you think about a patch like this one:
@@ ... { u32 msize = 0;
puts ("Initializing\n"); msize = fixed_sdram ();puts (" DDR RAM: "); return msize;}
Kim is really the one to be answering this, but I'll chime in since I'm reading email now.
I'm all for making 83xx more like other boards where it makes sense. Unfortunately, I am personally not really aware of what other boards do, or what the U-Boot norm is, so I would need to be told on a case-by-case basis what is different about 83xx.
I think something like this should be applied toi the following files:
board/sbc8349/sbc8349.c board/mpc832xemds/mpc832xemds.c board/mpc8360emds/mpc8360emds.c board/freescale/mpc8323erdb/mpc8323erdb.c board/mpc8349itx/mpc8349itx.c board/mpc8349emds/mpc8349emds.c board/mpc8313erdb/sdram.c
Also, if I understand this correctly, these files use a hardwired memory size. I this correct?
I think so. There is a define for the memory size, but off the top of my head, I think it's only use to saw the LAWBAR.
Do you have any plans to bring this in line with the normal U-Boot design philisophy which uses the memsize() function to automatically detect and adjust for the size of memory really present on a board, allowing to use the same image on differing configurations?
I don't know of any plans, but then, I didn't know it was a problem.