On 10/06/2017 02:08 PM, Alexander Graf wrote:
On 05.10.17 16:35, Heinrich Schuchardt wrote:
This patch series focuses on
- correction of parameter types for boot services
- fixes for the SetMem and CopyMem boot services
- fixes for the simple network protocol implementation (SNP)
- a unit test for SetMem, CopyMem and the simple network protocol
The unit test broadcasts a DHCPDISCOVER messager over the network and receives the reply.
This patch series is based on
- efi-next tree https://github.com/agraf/u-boot/tree/efi-next
- [PATCH 1/1] efi_selftest: enable CONFIG_CMD_BOOTEFI_SELFTEST https://patchwork.ozlabs.org/patch/816412/ This patch enables the unit test on qemu-x86_defconfig
- [PATCH 1/1] efi_loader: provide function comments for boot services https://patchwork.ozlabs.org/patch/817010/
Looks quite good to me. I've applied them (with the modification I suggested), running through tests and will push them to master if nobody (human or machine) objects within the next 1-2 days.
Alex
You moved setting is_signaled to efi_net_push.
181 static void efi_net_push(void *pkt, int len) 182 { 183 new_rx_packet = true; 184 wait_for_packet->is_signaled = true; 185 }
The code looks fine to me.
The selftest for the Simple Network Protocol correctly receives a DHCP packet.
Thank you.
I just sent you a fix for efi_st_memcmp: [PATCH 1/1] efi_selftest: efi_st_memcmp return difference of bytes
Best regards
Heinrich