On Fri, Dec 15, 2017 at 2:45 PM, Kever Yang kever.yang@rock-chips.com wrote:
Hi Jagan,
Could you enable global DEBUG and share the log?Thanks,
- Kever
On 12/15/2017 03:08 PM, Jagan Teki wrote:
Hi Philipp/Kever,
Issue observed on rk3288 TPL supported board (vyasa), worked on previous release v2017.11.
Tried to bisect but i couldn't do it because of changes in many files any help?
I don't understand how rk3288 boards were working since from 2 releases, I've bisect this and found the bad
d962e5dadc2cbc21bffd375f29665e5042879e66 is the first bad commit commit d962e5dadc2cbc21bffd375f29665e5042879e66 Author: Kever Yang kever.yang@rock-chips.com Date: Tue Oct 10 16:21:04 2017 +0200
rockchip: mkimage: use spl_boot0 for all Rockchip SoCs
Enable the spl_boot0 in SPL and use the pre-padding TAG memory, the mkimage do not need to pad it but only need to replace the value with correct TAG value.
Signed-off-by: Kever Yang kever.yang@rock-chips.com [Updated:] Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com
Look like the boot magic can't find it in 0x800 and it can't overwrite 4 bytes, so we need to explicitly specify 0x804 as header size
--- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -357,7 +357,7 @@ int rkcommon_vrec_header(struct image_tool_params *params, * 4 bytes of these images can safely be overwritten using the * boot magic. */ - tparams->header_size = RK_SPL_HDR_START; + tparams->header_size = RK_SPL_HDR_START + 4;
/* Allocate, clear and install the header */ tparams->hdr = malloc(tparams->header_size);
Please let me know for comments.
Jagan.