Re: [U-Boot] [PATCH 11/13] drivers/video/ct69000.c: Fix GC 4.6 build warning

On Wednesday 09 November 2011 14:29:04 Wolfgang Denk wrote:

Convert custom debug code to use standard debug() facility. This also fixes these build warning: ct69000.c: In function 'FindAndSetPllParamIntoXrRegs': ct69000.c:706:28: warning: variable 'new_pixclock' set but not used [-Wunused-but-set-variable]

--- a/drivers/video/ct69000.c +++ b/drivers/video/ct69000.c

#undef VGA_DEBUG #undef VGA_DUMP_REG #ifdef VGA_DEBUG -#define PRINTF(fmt,args...) printf (fmt ,##args) +#undef _DEBUG +#define _DEBUG 1 #else -#define PRINTF(fmt,args...) +#undef _DEBUG +#define _DEBUG 0 #endif

so do you still need this ? since you've converted to debug(), looks like this logic can all go away. -mike