On 15:41 Wed 12 Mar , Nobuhiro Iwamatsu wrote:
Signed-off-by: Nobuhiro Iwamatsu iwamatsu@nigauri.org
cpu/sh4/Makefile | 2 +- cpu/sh4/pci-sh7751.c | 204 ++++++++++++++++++++++++++++++++++++++++++++++++++ include/asm-sh/pci.h | 4 +- 3 files changed, 208 insertions(+), 2 deletions(-) create mode 100644 cpu/sh4/pci-sh7751.c
diff --git a/cpu/sh4/Makefile b/cpu/sh4/Makefile index 7a53cb6..6dc8a59 100644 --- a/cpu/sh4/Makefile +++ b/cpu/sh4/Makefile @@ -30,7 +30,7 @@ LIB = $(obj)lib$(CPU).a
START = start.o OBJS = cpu.o interrupts.o watchdog.o time.o cache.o \
pci-sh4.o pci-sh7780.o
pci-sh4.o pci-sh7751.o pci-sh7780.o
Could you split it to one line for one file
all: .depend $(START) $(LIB)
diff --git a/cpu/sh4/pci-sh7751.c b/cpu/sh4/pci-sh7751.c new file mode 100644 index 0000000..86d64dd --- /dev/null +++ b/cpu/sh4/pci-sh7751.c @@ -0,0 +1,204 @@ +/*
- SH7751 PCI Controller (PCIC) for U-Boot.
- (C) Dustin McIntire (dustin@sensoria.com)
- (C) 2007,2008 Nobuhiro Iwamatsu iwamatsu@nigauri.org
- See file CREDITS for list of people who contributed to this
- project.
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License as
- published by the Free Software Foundation; either version 2 of
- the License, or (at your option) any later version.
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- MA 02111-1307 USA
- */
+#include <common.h>
+#if defined(CONFIG_PCI) && defined(CONFIG_SH4_PCI) \
- && defined(CONFIG_SH7751_PCI)
Could you move it to the Makefile
+#include <asm/processor.h> +#include <asm/io.h> +#include <pci.h>
I think it will be good to move the pci drivers to drivers/pci
Best Regards, J.