On Wed, Oct 22, 2008 at 11:49:44PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
On 02:29 Fri 15 Aug , Sergey Lapin wrote:
Dear Jean-Christophe, thanks a lot for your review.
Are you from ADI?
No, but this file structure is a lot based on blackfin watchdog and I have too little code to make it int full intellectual property, IMHO.
- Licensed under the GPL-2 or later.
- */
+#include <common.h> +#include <watchdog.h> +#include <asm/arch/hardware.h> +#include <asm/arch/io.h>
+#ifdef CONFIG_HW_WATCHDOG
no need please remove
Ok,
+#define AT91_WDT_CR (AT91_WDT+0x00)
^please add space arround '+'
Ok.
+#define AT91_WDT_MR (AT91_WDT+0x04) +#define AT91_WDT_SR (AT91_WDT+0x08)
+void hw_watchdog_reset(void) +{
- at91_sys_write(AT91_WDT_CR, 0xa5000001);
^^^^ please use macro you can import them from Linux
Is this kind of watchdog supported in Linux already? When I submitted this file it was not yet.
All the best, S.