Re: [U-Boot] [PATCH v4 3/4] generic board patch of manual reloc and zero gd_t

On Tue, 2013-08-20 at 23:27 -0600, Simon Glass wrote:

Hi David,

On Tue, Aug 20, 2013 at 4:48 AM, fenghua@phytium.com.cn wrote:

...

diff --git a/common/board_r.c b/common/board_r.c index 86ca1cb..1b4bdd2 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -157,6 +157,13 @@ static int initr_reloc_global_data(void) */ gd->env_addr += gd->relocaddr - CONFIG_SYS_MONITOR_BASE; #endif +#ifdef CONFIG_NEEDS_MANUAL_RELOC

•   /*
  

•    * We have to relocate the command table manually
  

•    */
  

•   fixup_cmdtable(ll_entry_start(cmd_tbl_t, cmd),
  

•                   ll_entry_count(cmd_tbl_t, cmd));
  

+#endif /* CONFIG_NEEDS_MANUAL_RELOC */

Should this be done here or in main_loop()? How is this currently done when not using generic board?

It shouldn't be done at all -- let's not revive manual relocations. I'll try to get proper relocation working.

-Scott