Re: [RESEND PATCH 11/16] usb: gadget: Use dbg_ep0() macro instead of serial_printf()

On Fri, 5 Feb 2021 20:12:07 +0100 Pali Rohár pali@kernel.org wrote:

All debug messages from ep0.c except a few are printed by dbg_ep0() macro. So for remaining few exception use also dbg_ep0() instead of serial_printf().

Reviewed-by: Lukasz Majewski lukma@denx.de

Signed-off-by: Pali Rohár pali@kernel.org

drivers/usb/gadget/ep0.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/gadget/ep0.c b/drivers/usb/gadget/ep0.c index 457679f0a4..6624f61b76 100644 --- a/drivers/usb/gadget/ep0.c +++ b/drivers/usb/gadget/ep0.c @@ -294,7 +294,7 @@ static int ep0_get_descriptor (struct usb_device_instance *device, { struct usb_string_descriptor *string_descriptor; if (!(string_descriptor = usbd_get_string (index))) {

• 		serial_printf("Invalid string index
  

%d\n", index);

• 		dbg_ep0(0, "Invalid string index
  

%d\n", index); return -1; } dbg_ep0(3, "string_descriptor: %p length %d", string_descriptor, string_descriptor->bLength); @@ -302,14 +302,14 @@ static int ep0_get_descriptor (struct usb_device_instance *device, } break; case USB_DESCRIPTOR_TYPE_INTERFACE:

• serial_printf("USB_DESCRIPTOR_TYPE_INTERFACE - error not

implemented\n");

• dbg_ep0(2, "USB_DESCRIPTOR_TYPE_INTERFACE - error
  

not implemented\n"); return -1; case USB_DESCRIPTOR_TYPE_ENDPOINT:

• serial_printf("USB_DESCRIPTOR_TYPE_ENDPOINT - error
  

not implemented\n");

• dbg_ep0(2, "USB_DESCRIPTOR_TYPE_ENDPOINT - error not
  

implemented\n"); return -1; case USB_DESCRIPTOR_TYPE_HID: {

• 	serial_printf("USB_DESCRIPTOR_TYPE_HID -
  

error not implemented\n");

• 	dbg_ep0(2, "USB_DESCRIPTOR_TYPE_HID - error
  

not implemented\n"); return -1; /* unsupported at this time */ #if 0 int bNumInterface = @@ -338,7 +338,7 @@ static int ep0_get_descriptor (struct usb_device_instance *device, break; case USB_DESCRIPTOR_TYPE_REPORT: {

• 	serial_printf("USB_DESCRIPTOR_TYPE_REPORT -
  

error not implemented\n");

• 	dbg_ep0(2, "USB_DESCRIPTOR_TYPE_REPORT -
  

error not implemented\n"); return -1; /* unsupported at this time */ #if 0 int bNumInterface = @@ -531,7 +531,7 @@ int ep0_recv_setup (struct urb *urb) le16_to_cpu (request->wValue) & 0xff); case USB_REQ_GET_CONFIGURATION:

• 	serial_printf("get config %d\n",
  

device->configuration);

• 	dbg_ep0(2, "get config %d\n",
  

device->configuration); return ep0_get_one (device, urb, device->configuration);

@@ -621,14 +621,14 @@ int ep0_recv_setup (struct urb *urb) device->interface = device->alternate = 0;

	/*dbg_ep0(2, "set configuration: %d",

device->configuration); */

• 	/*serial_printf("DEVICE_CONFIGURED..
  

event?\n"); */

• 	/*dbg_ep0(2, "DEVICE_CONFIGURED..
  

event?\n"); */ return 0;

case USB_REQ_SET_INTERFACE:
	device->interface = le16_to_cpu

(request->wIndex); device->alternate = le16_to_cpu (request->wValue); /*dbg_ep0(2, "set interface: %d alternate: %d", device->interface, device->alternate); */

• 	serial_printf("DEVICE_SET_INTERFACE..
  

event?\n");

• 	dbg_ep0(2, "DEVICE_SET_INTERFACE..
  

event?\n"); return 0;

case USB_REQ_GET_STATUS:

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de